D1336: Summary: Removing ui.verbose check in the elif comdition.

pavanpc (Pavan Kumar PC) phabricator at mercurial-scm.org
Fri Nov 10 03:56:28 EST 2017


pavanpc added a comment.


  @mharbison72  Thank you for reviewing this diff. The diff checks for "not removing <filename>: file still exists". I have removed the ui.verbose check from elif.

INLINE COMMENTS

> mharbison72 wrote in cmdutil.py:2970
> Should ui.verbose be nested inside the elif instead?  The -v without -A case would have taken the 'else' case before, so this change seems to affect other things unintentionally.

@mharbison72  We should remove the ui.verbose check and check for verbose inside elif. I have made the change.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1336

To: pavanpc, #hg-reviewers
Cc: mitrandir, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list