D1336: Summary: Removing ui.verbose check in the elif comdition.

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Fri Nov 10 07:48:10 EST 2017

mharbison72 added a comment.

  @pavanpc this might just be me misreading phabricator, but you will want your summary to reflect the overall change, because all of the iterations on a single patch will be queued as a single commit. So maybe something like:
  remove: change the extant file warning with -A to verbose output
  Otherwise, there’s output for every file in the path on which the operation occurs.
  — — —  (end of commit message) — — —
  See here for formatting requirements: https://www.mercurial-scm.org/wiki/ContributingChanges


> cmdutil.py:2981
> +                        % m.rel(f))
> +                ret = 1
> +            ui.progress(_('skipping'), None)

Sorry I missed this before, but it looks like the return code is changed based on if this case happens. So the “ret = 1” line needs to happen outside of the ui.verbose check.

  rHG Mercurial


To: pavanpc, #hg-reviewers
Cc: mitrandir, mharbison72, mercurial-devel

More information about the Mercurial-devel mailing list