[PATCH 3 of 3] hgweb: add missing semicolons to followlines.js

Augie Fackler raf at durin42.com
Fri Nov 10 17:28:33 EST 2017


On Fri, Nov 10, 2017 at 08:39:06PM +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov <av6 at dwimlabs.net>
> # Date 1510312446 -28800
> #      Fri Nov 10 19:14:06 2017 +0800
> # Node ID 981d7ebd7dc74a88493f39982649a52ed09a199b
> # Parent  95cb67784e3c0d05e24e387acda45fd1c8aa4653
> hgweb: add missing semicolons to followlines.js

Queued, thanks.

>
> Minor stylistic issues caught by jshint.

Should we have some sort of test-jshint.t that can automatically run?
or does it have lots of false positives?

>
> diff --git a/mercurial/templates/static/followlines.js b/mercurial/templates/static/followlines.js
> --- a/mercurial/templates/static/followlines.js
> +++ b/mercurial/templates/static/followlines.js
> @@ -38,7 +38,7 @@ document.addEventListener('DOMContentLoa
>      // element
>      var selectableElements = Array.prototype.filter.call(
>          sourcelines.children,
> -        function(x) { return x.tagName === selectableTag });
> +        function(x) { return x.tagName === selectableTag; });
>
>      var btnTitleStart = 'start following lines history from here';
>      var btnTitleEnd = 'terminate line block selection here';
> @@ -62,7 +62,7 @@ document.addEventListener('DOMContentLoa
>      }
>
>      // extend DOM with CSS class for selection highlight and action buttons
> -    var followlinesButtons = []
> +    var followlinesButtons = [];
>      for (var i = 0; i < selectableElements.length; i++) {
>          selectableElements[i].classList.add('followlines-select');
>          var btn = createButton();
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list