D821: unamend: move fb extension unamend to core
durham (Durham Goode)
phabricator at mercurial-scm.org
Fri Nov 10 18:45:36 EST 2017
durham accepted this revision.
durham added a comment.
Overall looks good to me. My one comment is probably not enough to block this going in.
> + prednode = markers.prednode()
> + predctx = unfi[prednode]
Might be worth doing the predecessor check in the lock as well, since the result of this verification could technically change between now and when the lock is taken.
To: pulkit, #hg-reviewers, durham
Cc: ryanmce, singhsrb, durham, mercurial-devel
More information about the Mercurial-devel