[PATCH 3 of 3] hgweb: add missing semicolons to followlines.js
av6 at dwimlabs.net
Sat Nov 11 02:43:37 EST 2017
On Fri, 10 Nov 2017 17:28:33 -0500
Augie Fackler <raf at durin42.com> wrote:
> On Fri, Nov 10, 2017 at 08:39:06PM +0800, Anton Shestakov wrote:
> > # HG changeset patch
> > # User Anton Shestakov <av6 at dwimlabs.net>
> > # Date 1510312446 -28800
> > # Fri Nov 10 19:14:06 2017 +0800
> > # Node ID 981d7ebd7dc74a88493f39982649a52ed09a199b
> > # Parent 95cb67784e3c0d05e24e387acda45fd1c8aa4653
> > hgweb: add missing semicolons to followlines.js
> Queued, thanks.
> > Minor stylistic issues caught by jshint.
> Should we have some sort of test-jshint.t that can automatically run?
> or does it have lots of false positives?
Not a lot, no. And there are plenty of things to tweak:
Detecting its availability can be tricky though. It's not as widespread
as even pyflakes, for example there's no node-jshint package in Debian
or Ubuntu. And not everybody is fine using npm install --global (and
messing with their distro's package manager), so my guess is that most
of the time it's installed, it's installed somewhere local, which makes
it impossible to detect and use in a test.
But installing locally, putting a symlink into ~/bin and adding ~/bin
to $PATH does the trick. It's not a very user-friendly way to install a
dependency for just one test file, but it works. Patches sent.
More information about the Mercurial-devel