D1340: dirstate: add explicit methods for modifying dirstate
mbthomas (Mark Thomas)
phabricator at mercurial-scm.org
Sat Nov 11 07:59:19 EST 2017
mbthomas added inline comments.
> durin42 wrote in dirstate.py:1196
> Per my comment above, let's insert a patch before this one that documents in more detail the API that dirstatemap is supposed to be providing, probably in a docstring on this class. Sound reasonable?
> (Then the above docstring I complained about could point to this docstring.)
Agreed. I removed the docstring above because it became a lie (we no longer implement `__setitem__` or `__delitem__`, so it's not really a dict any more). I will add a docstring here on Monday.
To: mbthomas, #hg-reviewers, durin42
Cc: durin42, mbolin, mercurial-devel
More information about the Mercurial-devel