D1372: bundlerepo: make methods agree with base class

dlax (Denis Laxalde) phabricator at mercurial-scm.org
Sun Nov 12 03:10:41 EST 2017


dlax added a comment.


  > For methods that are implemented, we change arguments to match the base.
  
  Alternatively, we could use `**kwargs` for keywords arguments unused in a method. I think that's a common pattern and it avoids confusing the reader with unused arguments.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1372

To: indygreg, #hg-reviewers
Cc: dlax, mercurial-devel


More information about the Mercurial-devel mailing list