[POLL] Mass renaming options for consistency + guidelines

Yuya Nishihara yuya at tcha.org
Sun Nov 12 04:42:42 EST 2017


On Sat, 14 Oct 2017 14:02:03 +0900, Yuya Nishihara wrote:
> On Sat, 14 Oct 2017 00:41:04 -0400, Augie Fackler wrote:
> > > On Oct 14, 2017, at 12:38 AM, Martin von Zweigbergk <martinvonz at google.com> wrote:
> > > On Fri, Oct 13, 2017 at 9:33 PM, Augie Fackler <raf at durin42.com> wrote:
> > > > On Jul 19, 2017, at 10:14 AM, Augie Fackler <raf at durin42.com> wrote:
> > > >> On Jul 19, 2017, at 09:11, Yuya Nishihara <yuya at tcha.org> wrote:
> > > >>
> > > >>>> I prefer not doing mass renaming that would generate lots of "deprecated"
> > > >>>> config names in use around user hgrc and web documents. But if I had to
> > > >>>> choose one, I would vote for dashes/hyphens.
> > > >>>
> > > >>> We could also do what gmail does with email addresses and periods:
> > > >>> they allow extra periods anywhere (I think). So allowpull and
> > > >>> allow-pull and all-owpull would be all be the same config option. Just
> > > >>> a thought; I'm not sure what I think.
> > > >>
> > > >> I'm not a fan of ambiguating identifiers. It smells like case-insensitive fs,
> > > >> computer language, etc. that do sometimes surprising.
> > > >
> > > > Agreed. I had previously proposed exactly this, but in the intervening years I've come to agree with Yuya that it's likely to be more confusing than anything in the long run.
> > > 
> > > So, in reviewing https://phab.mercurial-scm.org/D932, it was noted that https://www.mercurial-scm.org/wiki/UIGuideline?action=diff&rev1=10&rev2=11 concluded that there was a decision, but I don’t see any kind of consensus on this thread. Are we comfortable with this as the guidance going forward?
> > > 
> > > I am, but I wanted to make sure there’s some well-documented consensus of the policy change.
> > > 
> > > Me too. Hyphen-separated words sounds good (just repeating that here to clarify that that is the decision we're talking about).
> > 
> > Yep, that’s the one. Right now, my understanding of positions on hyphen-separated-words is as follows:
> > 
> > durin42: +1
> > martinvonz: +1
> > David Demelier: +1
> > Yuya: ? (I think +0 on hyphens at least for new config knobs?)
> 
> Yep, +0. More precisely:
> 
>  * okay: allow_pull
>  * preferred: allow-pull
>  * also preferred: allowpull
> 
> FWIW, dashes can't be used in some config sections.
> 
>  * [hooks] - pre-/post- is reserved for command hooks
>  * [revsetaliases], [templatealiases] - name must be a valid symbol

So we're agreed to do the mass renaming, right?
I thought it was only for new options, but maybe I was wrong.


More information about the Mercurial-devel mailing list