D1372: bundlerepo: make methods agree with base class

lothiraldan (Boris Feld) phabricator at mercurial-scm.org
Mon Nov 13 02:37:59 EST 2017

lothiraldan added a comment.

  In https://phab.mercurial-scm.org/D1372#22814, @dlax wrote:
  > > For methods that are implemented, we change arguments to match the base.
  > Alternatively, we could use `**kwargs` for keywords arguments unused in a method. I think that's a common pattern and it avoids confusing the reader with unused arguments.
  👍 for using `**kwargs` and even maybe `*args` if necessary.

  rHG Mercurial


To: indygreg, #hg-reviewers
Cc: lothiraldan, dlax, mercurial-devel

More information about the Mercurial-devel mailing list