D1378: bundlerepo: assign bundle attributes in bundle type blocks
dlax (Denis Laxalde)
phabricator at mercurial-scm.org
Mon Nov 13 03:05:38 EST 2017
dlax added inline comments.
INLINE COMMENTS
> bundlerepo.py:298
>
> - self._handlebundle2part(part)
> + self._handlebundle2part(bundle, part)
>
Within `_handlebundle2part`, there's still a `self._bundle = changegroup.getunbundler(...)` statement. Perhaps, it'd be even clearer if this method would `return changegroup.getunbundler(...)` and let the caller eventually assign this as an attribute.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1378
To: indygreg, #hg-reviewers, dlax
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list