D1336: remove: print message for each file in verbose mode only while using `-A`

pavanpc (Pavan Kumar PC) phabricator at mercurial-scm.org
Mon Nov 13 05:40:17 EST 2017

pavanpc added a comment.

  @lothiraldan  I modified a test case for hg rm -A <filename> case where we get the message 'not removing <filename>: file still exists' . For other cases, test cases already exist with 'hg rm -A' and 'hg rm --after' without verbose mode.


> mharbison72 wrote in cmdutil.py:2982
> This will need to be protected by seeing if there are any files in modified + added + clean, like it was before.  Otherwise, using -A will always return non zero, even if it succeeded without warning cases.  Maybe hoist the 'remaining = ...' line out of the conditional?

Moved the 'remaining ' outside the conditional. Making the ui.verbose check only while adding it to the warnings list

  rHG Mercurial


To: pavanpc, #hg-reviewers
Cc: lothiraldan, mitrandir, mharbison72, mercurial-devel

More information about the Mercurial-devel mailing list