D1371: global: remove redundant parenthesis

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon Nov 13 08:47:36 EST 2017


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> revsetlang.py:298
>          # x + y + z -> (or x y z) -> (or (list x y z))
> -        return (op, _fixops(('list',) + x[1:]))
>      elif op == 'subscript' and x[1][0] == 'relation':

I don't like this sort of changes because here a tuple is a
data structure used thoroughly, not an arbitrary set of values
to be returned.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1371

To: indygreg, #hg-reviewers, yuja
Cc: yuja, dlax, mercurial-devel


More information about the Mercurial-devel mailing list