D1348: histedit: add support to output nodechanges using formatter
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Mon Nov 13 09:05:48 EST 2017
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> histedit.py:1208
> + fd = fm.formatdict
> + nodechanges = fd({hf(oldn): fl([hf(n) for n in newn], 'succ')
> + for oldn, newn in mapping.iteritems()})
Can you fix the formatter issue in rebase.py first so we won't
have to apply the same change again on histedit.py?
Probably we wouldn't want to call `hf(oldn)` and `fl([hf(n)...])` as `{key}` and `{value}` in template respectively. I think something
like `{oldnode}` and `{newnodes}` would be better, but I don't
know what are the correct terms here.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1348
To: pulkit, durin42, #hg-reviewers, dlax, yuja
Cc: yuja, dlax, mercurial-devel
More information about the Mercurial-devel
mailing list