D1358: remotenames: store journal entry for bookmarks if journal is loaded

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Mon Nov 13 17:13:54 EST 2017


durin42 added a comment.


  In https://phab.mercurial-scm.org/D1358#22899, @smf wrote:
  
  > pulkit (Pulkit Goyal) <phabricator at mercurial-scm.org> writes:
  >
  > > pulkit created this revision.
  > >  Herald added a subscriber: mercurial-devel.
  > >  Herald added a reviewer: hg-reviewers.
  > > 
  > > REPOSITORY
  > > 
  > >   rHG Mercurial
  > > 
  > > REVISION DETAIL
  > > 
  > >   https://phab.mercurial-scm.org/D1358
  > > 
  > > AFFECTED FILES
  > > 
  > >   mercurial/remotenames.py
  > > 
  > > CHANGE DETAILS
  > > 
  > > diff --git a/mercurial/remotenames.py b/mercurial/remotenames.py
  > > 
  > > - a/mercurial/remotenames.py +++ b/mercurial/remotenames.py
  >
  > A bit jumping the gun, no? I don't think we should be skipping putting
  >  this initial stuff into hgext/remotenames.py.
  
  
  I don't think so. IMO the storage-only parts can and should go straight in core and be on by default. Exposing the data (by default, at least) we're collecting should probably go through an extension rodeo first.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1358

To: pulkit, #hg-reviewers
Cc: durin42, smf, dlax, mercurial-devel


More information about the Mercurial-devel mailing list