D1372: bundlerepo: make methods agree with base class
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Mon Nov 13 17:15:39 EST 2017
durin42 added a comment.
In https://phab.mercurial-scm.org/D1372#22818, @lothiraldan wrote:
> In https://phab.mercurial-scm.org/D1372#22814, @dlax wrote:
> > > For methods that are implemented, we change arguments to match the base.
> > Alternatively, we could use `**kwargs` for keywords arguments unused in a method. I think that's a common pattern and it avoids confusing the reader with unused arguments.
> 👍 for using `**kwargs` and even maybe `*args` if necessary.
The standard we've recently moved to at Google is to allow `del foo # unused` for unused arguments, so they're forcibly unused, but also still demonstrably passed. It makes things easier overall for various inference tools, and I'd be happy to adopt that in hg too.
To: indygreg, #hg-reviewers
Cc: durin42, lothiraldan, dlax, mercurial-devel
More information about the Mercurial-devel