D821: unamend: move fb extension unamend to core

[durin42 (Augie Fackler)]

durin42 added inline comments.

INLINE COMMENTS

> uncommit.py:247
> +def unamend(ui, repo, **opts):
> +    """undo the amend operation on a current changeset
> +

undo the _most recent_ amend? or can I run this iteratively and undo many amends in sequence?

> uncommit.py:265
> +        markers = list(predecessormarkers(curctx))
> +        if len(markers) != 1:
> +            e = _("changeset must have one predecessor, found %i predecessors")

Should we also look for unamend_source in the extra, and potentially refuse to unamend an unamend? Or not?

> uncommit.py:273
> +        if curctx.children():
> +            raise error.Abort(_("cannot unamend in the middle of a stack"))
> +

cannot unamend a changeset with children

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D821

To: pulkit, #hg-reviewers, durham
Cc: durin42, ryanmce, singhsrb, durham, mercurial-devel