D939: remotenames: add functionality to store remotenames under .hg/hgremotenames/

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Mon Nov 13 17:31:26 EST 2017


durin42 added a comment.


  I'm confused by the state of this diff - it appears to be modifying a file which doesn't yet exist in hg?

INLINE COMMENTS

> pulkit wrote in test-remotenames.t:69
> @durin42 related to your comment on list[0], is space separated format okay or null separated is preferred?
> 
> [0]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-November/107528.html

This is sort of okay, but won't scale well. I'd rather we used something we know we'll never see in a path like NUL rather than space separated, but this is probably fine.

I might bias towards making the first line an int followed by a newline so we can easily iterate on the file format and migrate things in the future.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D939

To: pulkit, #hg-reviewers, dlax, ryanmce
Cc: durin42, ryanmce, dlax, mercurial-devel


More information about the Mercurial-devel mailing list