D1347: dirstate: make map implementation overridable
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Mon Nov 13 17:36:44 EST 2017
durin42 added subscribers: mbolin, durin42.
durin42 accepted this revision as: durin42.
durin42 added a comment.
I'd prefer this as a class attr, but would like to hear from @mbolin as to whether or not that solves the problem(s) that inspired https://phab.mercurial-scm.org/D1354.
INLINE COMMENTS
> dirstate.py:83
> self._updatedfiles = set()
> + self._mapcls = dirstatemap
>
Could you set this at class-level, rather than in __init__? I think then @mbolin would be able to make his subclass replace the class attribute and that'd be sufficient?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1347
To: mbthomas, #hg-reviewers, durin42
Cc: durin42, mbolin, mercurial-devel
More information about the Mercurial-devel
mailing list