D1346: fsmonitor: only access inner dirstate map if it is available
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Mon Nov 13 17:50:04 EST 2017
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> __init__.py:279
> + # directly access the inner dirstate map if the standard dirstate
> + # implementation is in use.
> + dmap = dmap._map
Do we do this for perf reasons? If so, add a comment.
(Maybe check and see if this shows up on perfdirstate or similar - if it does, document that in the commit message with numbers, and then you don't even need a comment because we'll find that with blame.)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1346
To: mbthomas, #hg-reviewers, durin42
Cc: durin42, mercurial-devel
More information about the Mercurial-devel
mailing list