D1354: dirstate: change all writes to dirstatemap._map to go through one method

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Mon Nov 13 19:02:00 EST 2017


durin42 added a comment.


  In https://phab.mercurial-scm.org/D1354#22991, @mbolin wrote:
  
  > @durin42 The issue is that `dirstatemap` is doing so much "stuff" beyond just storage that Eden prefers to subclass it rather than copy/paste all of the business logic.
  
  
  That's an argument for further splitting dirstatemap. That said, does https://phab.mercurial-scm.org/D1347 resolve the specific concern that motivated this change?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1354

To: mbolin, mbthomas, durham, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list