D1345: dirstate: add explicit methods for querying directories

[mbthomas (Mark Thomas)]

mbthomas added inline comments.

INLINE COMMENTS

> mbolin wrote in dirstate.py:393
> Can you just use `hasdir` here instead so there's only one thing to override?

The external dirstate object only provides `hasdir()`, however the internal object needs to provide two objects as there are two behaviours it needs to expose:

`hastrackeddir()` considers only files that are not marked as removed.  This is used almost everywhere.

`hasdir()` additionally considers directories that contain only removed files.  This is used in one place below (line 803).  I don't understand what `_walkexplicit` is trying to do, so I haven't changed it.  I'm not convinced `_walkexplicit` is correct, though.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1345

To: mbthomas, #hg-reviewers, durin42
Cc: durin42, mbolin, mercurial-devel