D1426: logtoprocess: add the possibility to not start a shell

mbthomas (Mark Thomas) phabricator at mercurial-scm.org
Wed Nov 15 12:18:05 EST 2017


mbthomas accepted this revision.
mbthomas added inline comments.

INLINE COMMENTS

> logtoprocess.py:65
>              subprocess.Popen(
> -                script, shell=True, env=env, close_fds=True,
> +                script, shell=shell, env=env, close_fds=True,
>                  creationflags=_creationflags)

On unix systems `shell=False` means the command provided cannot take any arguments, as it's the shell that does the argument splitting.  I am guessing that this is OK, as we'll just never configure `logtoprocess.shell` as False on unix systems.  Is that right?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1426

To: lothiraldan, #hg-reviewers, mbthomas
Cc: mbthomas, mercurial-devel


More information about the Mercurial-devel mailing list