D1358: remotenames: store journal entry for bookmarks if journal is loaded
quark (Jun Wu)
phabricator at mercurial-scm.org
Wed Nov 15 13:57:43 EST 2017
quark added a comment.
In https://phab.mercurial-scm.org/D1358#23388, @smf wrote:
> 1. Create a v1 storage format api to hold this information (maybe start with sqlite or something very simple at first for the backend)
- Some people use traditional tools like `grep`, `less` on `blackbox.log`. Using sqlite would make blackbox harder to use.
- sqlite calls `fsync` by default. It's a performance issue under heavy I/O.
> 2. Create a helper utility (decorator, or just wrap ui, etc)
> 3. Use helper utility on all these commands to keep the data extension-agnostic
The current APIs (ui.log and repo.journal.record) do not look
terrible. Could you give an example of how this diff could be
improved with your proposed new API? i.e. is it becoming shorter,
If the code under the new API look similar to the existing one,
I wonder whether they could be implemented independently - i.e.
this series continue using the existing API and changing the
format is independent from this series.
To: pulkit, #hg-reviewers
Cc: quark, durin42, smf, dlax, mercurial-devel
More information about the Mercurial-devel