D1431: sshpeer: making the ssh error message configurable
durham (Durham Goode)
phabricator at mercurial-scm.org
Wed Nov 15 21:05:10 EST 2017
durham requested changes to this revision.
durham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> sshpeer.py:210
> + "errormessage",
> + _("no suitable response from remote hg"))))
>
The standard Mercurial way to format this would be something like:
msg = self.ui.config("ssh", "errormessage",
_("no suitable response from remote hg"))
self._abort(error.RepoError(msg))
> test-ssh.t:314
> +
> +
> clone bookmarks
These lines seem unrelated to your change and therefore probably shouldn't have changed. Usually this is caused by your editor trying to remove trailing whitespace from a file, then run-tests -i adding the missing new line back in. Can you undo these new line changes? 'hg uncommit tests/test-ssh.t && hg commit -i' could make it pretty straightforward.
> test-ssh.t:447
> > from mercurial import exchange, extensions
> - >
> > def wrappedpush(orig, repo, *args, **kwargs):
Same for this type of change
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1431
To: zuza, #hg-reviewers, durham, mitrandir
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list