D1213: merge: remove calls to flushall()

phillco (Phil Cohen) phabricator at mercurial-scm.org
Thu Nov 16 00:13:33 EST 2017


phillco updated this revision to Diff 3552.

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1213?vs=3062&id=3552

REVISION DETAIL
  https://phab.mercurial-scm.org/D1213

AFFECTED FILES
  mercurial/merge.py

CHANGE DETAILS

diff --git a/mercurial/merge.py b/mercurial/merge.py
--- a/mercurial/merge.py
+++ b/mercurial/merge.py
@@ -1308,10 +1308,6 @@
         repo.ui.warn(_("current directory was removed\n"
                        "(consider changing to repo root: %s)\n") % repo.root)
 
-    # It's necessary to flush here in case we're inside a worker fork and will
-    # quit after this function.
-    wctx.flushall()
-
 def batchget(repo, mctx, wctx, actions):
     """apply gets to the working directory
 
@@ -1351,9 +1347,6 @@
     if i > 0:
         yield i, f
 
-    # It's necessary to flush here in case we're inside a worker fork and will
-    # quit after this function.
-    wctx.flushall()
 
 def applyupdates(repo, actions, wctx, mctx, overwrite, labels=None):
     """apply the merge action list to the working directory
@@ -1454,10 +1447,6 @@
         z += 1
         progress(_updating, z, item=f, total=numupdates, unit=_files)
 
-    # We should flush before forking into worker processes, since those workers
-    # flush when they complete, and we don't want to duplicate work.
-    wctx.flushall()
-
     # get in parallel
     prog = worker.worker(repo.ui, cost, batchget, (repo, mctx, wctx),
                          actions['g'])
@@ -1979,7 +1968,6 @@
                   'see "hg help -e fsmonitor")\n'))
 
         stats = applyupdates(repo, actions, wc, p2, overwrite, labels=labels)
-        wc.flushall()
 
         if not partial:
             with repo.dirstate.parentchange():



To: phillco, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list