D1426: logtoprocess: add the possibility to not start a shell

lothiraldan (Boris Feld) phabricator at mercurial-scm.org
Thu Nov 16 04:09:26 EST 2017

lothiraldan added inline comments.


> mbthomas wrote in logtoprocess.py:65
> On unix systems `shell=False` means the command provided cannot take any arguments, as it's the shell that does the argument splitting.  I am guessing that this is OK, as we'll just never configure `logtoprocess.shell` as False on unix systems.  Is that right?

Right, I was not aware of this limitation.

If a company would deploy the same configuration for both Windows and Linux, we might have `shell=False` on Linux system but it would work well if the script doesn't take any argument or with an intermediary script that injects all the arguments, I will document it in the commit message and extensions documentation.

  rHG Mercurial


To: lothiraldan, #hg-reviewers, mbthomas
Cc: mbthomas, mercurial-devel

More information about the Mercurial-devel mailing list