D1431: sshpeer: making the ssh error message configurable
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Thu Nov 16 08:08:01 EST 2017
yuja added a comment.
In https://phab.mercurial-scm.org/D1431#23709, @durham wrote:
> I'd also update the commit summary with an example of what a better message might be. Like "there was an ssh error, please see http://company/internalwiki/ssh.html"
So the purpose of this change is quite similar to `ui.supportcontact`, right?
My two cents. I think it's probably better to make an additional `hint` configurable,
instead of replacing the original message.
> def badresponse():
> - self._abort(error.RepoError(_('no suitable response from '
> - 'remote hg')))
> + msg = self.ui.config("ssh", "errormessage",
> + _("no suitable response from remote hg"))
new config needs to be registered to the configitems module.
To: zuza, #hg-reviewers, durham, mitrandir
Cc: yuja, mercurial-devel
More information about the Mercurial-devel