[PATCH] hgweb: move changeset "tags" to a template in map file (paper and coal)

Yuya Nishihara yuya at tcha.org
Thu Nov 16 08:49:28 EST 2017


On Thu, 16 Nov 2017 14:31:48 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov <av6 at dwimlabs.net>
> # Date 1510761309 -28800
> #      Wed Nov 15 23:55:09 2017 +0800
> # Node ID 5ec3062f234c53970beae8b8d4f20b30cfa9f889
> # Parent  4a66b5969fd89cfec836b398aa3a7c3d4d827ed6
> # EXP-Topic hgweb-cleanup
> hgweb: move changeset "tags" to a template in map file (paper and coal)
> 
> This patch puts all these changeset "tags" into one template shared everywhere
> in paper and coal themes. But it should be noted that some of the templates had
> different sets of tags, in some cases it was intended, in others - most likely
> not.
> 
> First, what's up with all these different ways to get changeset's branch. There
> are actually 3 ways to do it in hgweb, they can all be seen in this patch;
> "branches", "inbranch" and "branch". They are all lists that consist of 1 or 0
> items:
> 
> - "branches" has ctx.branch() if current changeset is the tip of that branch
> - "inbranch" has ctx.branch() if current changeset is _not_ the tip of that
>   branch and the branch is not "default"
> - "branch" aka "changesetbranch" has ctx.branch() if the branch is not
>   "default"
> 
> The majority of cases (7 vs 2 + /graph) in paper theme used only option 3,
> which meant that "default" was never displayed. But other parts of the theme
> disagreed with this and used option 1 and option 2 together. For example, the
> default view (log) displays "default" on the branch tip (can be seen right
> about now on m-s.o/repo/hg), but it disappears when you click on the commit.
> 
> Also, using option 3 alone meant that there was no way to tell if a changeset
> is the tip of its branch or not (it was always assumed that it's not, see how
> some css classes change from "branchname" to the correct "branchhead" in tests)
> -- so the two different css styles that exist in paper just for this were
> underused.
> 
> I think this patch improves the situation, even though it changes the old (even
> if inconsistent) behavior. The new behavior matches that of gitweb and
> monoblue.

I like this, and a trivial BC in web UI should be allowed.
Queued, thanks.


More information about the Mercurial-devel mailing list