D1426: logtoprocess: add the possibility to not start a shell
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Thu Nov 16 09:27:34 EST 2017
yuja added a comment.
In https://phab.mercurial-scm.org/D1426#23803, @lothiraldan wrote:
> In https://phab.mercurial-scm.org/D1426#23797, @yuja wrote:
> > Can't we use `openflags=CREATE_NO_WINDOW` instead?
> > https://stackoverflow.com/a/7006424
> I tried lots of things including openflags=CREATE_NO_WINDOW that didn't seem to work, unfortunately.
Right. cmd.exe does allocates new console because the process is "DETACHED" from
the parent's console. I have no idea if `DETACH_PROCESS` is what we wanted.
>> `shell=False` also disables envar expansion, and I guess there would
>> be lots of trivial behavior changes.
> I'm not sure to understand what you mean, I tried this configuration:
> commandfinish = %HOMEPATH%/script.pl
> And `%HOMEPATH` seemed to be expanded.
Maybe it's resolved while looking up the executable path. I suspect
`script.pl %HOMEPATH%` wouldn't work.
To: lothiraldan, #hg-reviewers, mbthomas
Cc: yuja, mbthomas, mercurial-devel
More information about the Mercurial-devel