D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

[lothiraldan (Boris Feld)]

lothiraldan added inline comments.

INLINE COMMENTS

> yuja wrote in logtoprocess.py:89
> stdout and stderr should be writable. We can simply pass a file
> descriptor open with O_RDWR.
> 
>   nullfd = os.open(os.devnull, os.O_RDWR)
>   Popen(stdin=nullfd, stdout=nullfd, stderr=nullfd)
> 
> and `os.close(nullfd)` though it doesn't mater since the process
> is terminated with `_exit()`.

Thx for the catch, I will make the change.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1428

To: lothiraldan, #hg-reviewers, yuja
Cc: yuja, mercurial-devel