D1074: branch: add a --rev flag to change branch name of given revisions
lothiraldan (Boris Feld)
phabricator at mercurial-scm.org
Fri Nov 17 05:39:00 EST 2017
lothiraldan added a comment.
Looking good, should we allow changing the branch if any changeset is unstable or obsolete?
INLINE COMMENTS
> cmdutil.py:723
> + with repo.wlock(), repo.lock(), repo.transaction('branches'):
> + # abort incase in uncommitted merger of dirty wdir
> + bailifchanged(repo)
Small typo, missing space between `in` and `case`
> cmdutil.py:774
> + p2 = replacements[p2][0]
> +
> + mc = context.memctx(repo, (p1, p2),
For safety, I would add a check that p1 and p2 are not obsolete here.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1074
To: pulkit, #hg-reviewers, dlax, ryanmce
Cc: lothiraldan, ryanmce, dlax, mercurial-devel
More information about the Mercurial-devel
mailing list