D1433: run-tests: fix TESTDIR if testdescs are absolute paths

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Nov 17 08:33:11 EST 2017


yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.


  Queued, thanks. FIle APIs still accept bytes/unicode on Py3.

INLINE COMMENTS

> run-tests.py:2359
>              pathname = os.path.dirname(testdescs[0]['path'])
> -            if pathname and not osenvironb[b'TESTDIR'].endswith(b'/'):
> -                osenvironb[b'TESTDIR'] += b'/'
> -            osenvironb[b'TESTDIR'] += pathname
> +            osenvironb[b'TESTDIR'] = os.path.join(osenvironb[b'TESTDIR'],
> +                                                  pathname)

Restored `if pathname:` part, caught by test-run-tests.t

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1433

To: spectral, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list