D821: unamend: move fb extension unamend to core

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Fri Nov 17 09:14:54 EST 2017

pulkit added a subscriber: quark.
pulkit added inline comments.


> durin42 wrote in uncommit.py:247
> undo the _most recent_ amend? or can I run this iteratively and undo many amends in sequence?

Nice catch, it should be undo the _most recent_ amend. Thanks!

> durin42 wrote in uncommit.py:265
> Should we also look for unamend_source in the extra, and potentially refuse to unamend an unamend? Or not?

I don't think users will run unamend(1) and then will try to run unamend(2) again to unamend the first unamend. It's not intuitive in my opinion. @durham @quark what do you guys think here?

  rHG Mercurial


To: pulkit, #hg-reviewers, durham
Cc: quark, durin42, ryanmce, singhsrb, durham, mercurial-devel

More information about the Mercurial-devel mailing list