D1358: remotenames: store journal entry for bookmarks if journal is loaded

durham (Durham Goode) phabricator at mercurial-scm.org
Fri Nov 17 13:17:27 EST 2017

durham added a comment.

  There seems like two use cases for remotenames:  knowledge about the most recently seen location of each remote bookmark, and knowledge about where the remote bookmarks have been over time.  I think 99% of the benefit of remotenames comes from the first part.  Building a storage layer which suits both the journal and remotenames seems like massive scope creep to address the 1% use case.  Even if we did unify the storage models, I still don't believe remotenames and the journal could share a common storage format because they don't have similar access patterns.  Remotenames is much more of a random access dict-like object, while the journal is much more of a sequential log.  If I want to lookup the value of the latest remote master I don't want to deal with scanning some log of recent activity, and if I want to maintain a log of recent activity I don't want to build an index that allows for random access.

  rHG Mercurial


To: pulkit, #hg-reviewers
Cc: durham, quark, durin42, smf, dlax, mercurial-devel

More information about the Mercurial-devel mailing list