[PATCH 2 of 2] config: rename allow_push to allow-push

Martin von Zweigbergk martinvonz at google.com
Fri Nov 17 16:09:27 EST 2017


On Fri, Nov 17, 2017 at 1:04 PM, David Demelier <markand at malikania.fr> wrote:
> Le 17 nov. 2017 18:35, Martin von Zweigbergk <martinvonz at google.com> a écrit
> :
>
> On Fri, Nov 10, 2017 at 6:09 AM, David Demelier <markand at malikania.fr>
> wrote:
>> # HG changeset patch
>> # User David Demelier <markand at malikania.fr>
>> # Date 1508406401 -7200
>> #      Thu Oct 19 11:46:41 2017 +0200
>> # Node ID 7618db2f7c818bcfd73393fff45a13e50fa9250b
>> # Parent  4157480049dabdf7bd54160c909baf13ea8d5107
>> config: rename allow_push to allow-push
>>
>> diff -r 4157480049da -r 7618db2f7c81 mercurial/help/config.txt
>> --- a/mercurial/help/config.txt Thu Oct 19 11:43:19 2017 +0200
>> +++ b/mercurial/help/config.txt Thu Oct 19 11:46:41 2017 +0200
>> @@ -2290,13 +2290,13 @@
>>  ``allow-pull``
>>      Whether to allow pulling from the repository. (default: True)
>>
>> -``allow_push``
>> +``allow-push``
>>      Whether to allow pushing to the repository. If empty or not set,
>>      pushing is not allowed. If the special value ``*``, any remote
>>      user can push, including unauthenticated users. Otherwise, the
>>      remote user must have been authenticated, and the authenticated
>>      user name must be present in this list. The contents of the
>> -    allow_push list are examined after the deny_push list.
>> +    allow-push list are examined after the deny_push list.
>
>
> Hmm, it seems weird not to change deny_push in the same series. Could
> we have a patch for that too, please? (Or tell me what I'm missing.)
>
> all the hgrc will be taken in account :)

I assume they will be eventually. It's just in a weird state right
now. It's not the end of the world, of course, but it would have been
better to have those two renamed together.


More information about the Mercurial-devel mailing list