D1285: localrepo: add a new attribute _visibilityexceptions and related API

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Nov 20 14:48:04 EST 2017

pulkit added a comment.

  In https://phab.mercurial-scm.org/D1285#22442, @quark wrote:
  > I think `localrepo` object is usually for unfiltered access therefore the visibility exception API looks strange to me.
  > Maybe move them to the `repoview` layer?
  The functions to compute filtered set takes unfiltered repository, and we consider these changesets at that time, so unfiltered make sense.
  Also, having them at repoview layer will require a filtered repository to access the API's. This will make the use of API a bit difficult as it may throw an AttributeError if we are working with unfiltered repo or the user of the API has to know which filtername to use etc.

  rHG Mercurial


To: pulkit, #hg-reviewers
Cc: quark, mercurial-devel

More information about the Mercurial-devel mailing list