D1483: globalopts: make special flags ineffective after '--' (BC)

dlax (Denis Laxalde) phabricator at mercurial-scm.org
Tue Nov 21 15:01:03 EST 2017


dlax added inline comments.

INLINE COMMENTS

> dispatch.py:715
> +            return True
> +    return False
> +

I find the algorithm a bit clumsy (usage of both `in` and `.index()` for the same value), how about a for loop like that:

  for arg in args:
      if arg == optname:
          return True
      if arg == '--':
          return False
  return False

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1483

To: quark, #hg-reviewers
Cc: dlax, mercurial-devel


More information about the Mercurial-devel mailing list