D1499: hbisect: use a defaultdict to avoid large allocations for a large changelogs

dsp (David Soria Parra) phabricator at mercurial-scm.org
Fri Nov 24 23:30:39 EST 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8287df8b7be5: hbisect: use a defaultdict to avoid large allocations for a large changelogs (authored by dsp, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1499?vs=3805&id=3858

REVISION DETAIL
  https://phab.mercurial-scm.org/D1499

AFFECTED FILES
  mercurial/hbisect.py

CHANGE DETAILS

diff --git a/mercurial/hbisect.py b/mercurial/hbisect.py
--- a/mercurial/hbisect.py
+++ b/mercurial/hbisect.py
@@ -38,7 +38,7 @@
 
     def buildancestors(bad, good):
         badrev = min([changelog.rev(n) for n in bad])
-        ancestors = [None] * (len(changelog) + 1)
+        ancestors = collections.defaultdict(lambda: None)
         for rev in repo.revs("descendants(%ln) - ancestors(%ln)", good, good):
             ancestors[rev] = []
         if ancestors[badrev] is None:



To: dsp, #hg-reviewers, yuja
Cc: mercurial-devel


More information about the Mercurial-devel mailing list