D1555: py3: add pycompat.basestring and use it

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Thu Nov 30 07:16:08 EST 2017


yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  Testing a unicode string is probably wrong since almost all "strings" in Mercurial
  must be bytes. Perhaps these `basestring`s can be replaced with `bytes`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1555

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list