D1553: contrib: improve check-code ban on $LOCALIP in output without (glob)
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Thu Nov 30 07:58:48 EST 2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG273907306a39: contrib: improve check-code ban on $LOCALIP in output without (glob) (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1553?vs=3976&id=4010
REVISION DETAIL
https://phab.mercurial-scm.org/D1553
AFFECTED FILES
contrib/check-code.py
CHANGE DETAILS
diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -197,7 +197,7 @@
'write "file:/*/$TESTTMP" + (glob) to match on windows too'),
(r'^ [^$>].*27\.0\.0\.1',
'use $LOCALIP not an explicit loopback address'),
- (r'^ [^$>].*\$LOCALIP.*[^)]$',
+ (r'^ (?![>$] ).*\$LOCALIP.*[^)]$',
'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),
(r'^ (cat|find): .*: No such file or directory',
'use test -f to test for file existence'),
To: durin42, #hg-reviewers, lothiraldan, yuja
Cc: lothiraldan, mercurial-devel
More information about the Mercurial-devel
mailing list