D1564: worker: make windows workers daemons

durham (Durham Goode) phabricator at mercurial-scm.org
Thu Nov 30 16:29:38 EST 2017


durham added inline comments.

INLINE COMMENTS

> worker.py:286
> +                threads.remove(t)
> +    except KeyboardInterrupt:
> +        trykillworkers()

Why only do it on keyboard interrupt?  What if there's another exception?  If you did it for all exceptions, you could drop the trykillworkers() inside the loop, and just throw the exception up to here.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1564

To: wlis, #hg-reviewers, ikostia
Cc: durham, ikostia, mercurial-devel


More information about the Mercurial-devel mailing list