D1564: worker: make windows workers daemons

wlis (Wojciech Lis) phabricator at mercurial-scm.org
Thu Nov 30 16:39:24 EST 2017


wlis added inline comments.

INLINE COMMENTS

> durham wrote in worker.py:286
> Why only do it on keyboard interrupt?  What if there's another exception?  If you did it for all exceptions, you could drop the trykillworkers() inside the loop, and just throw the exception up to here.

this is a very good point. will do.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1564

To: wlis, #hg-reviewers, ikostia
Cc: durham, ikostia, mercurial-devel


More information about the Mercurial-devel mailing list