D849: hgweb: query string arguments to control whitespace for annotate

simpkins (Adam Simpkins) phabricator at mercurial-scm.org
Sun Oct 1 10:22:33 UTC 2017


simpkins accepted this revision.
simpkins added a comment.


  Looks good to me apart from one minor question.

INLINE COMMENTS

> webutil.py:180-183
> +            try:
> +                v = bool(int(v))
> +            except ValueError:
> +                v = True

Would it be better to use `util.parsebool()` here?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D849

To: indygreg, #hg-reviewers, simpkins
Cc: simpkins, mercurial-devel


More information about the Mercurial-devel mailing list