D865: obsmarker: fix crash when metadata fields are >255 bytes (issue5681)

ikostia (Kostia Balytskyi) phabricator at mercurial-scm.org
Sun Oct 1 07:09:18 EDT 2017


ikostia added a comment.


  That is why we raise `ProgrammingError`, not some sort of `UserError`. If your extension writes metadata longer than 255 chars, it is a bad extension. Your proposal is weird, because it is quietly modifying things, IMO this is much worse. I'd rather be forced to change my name to something shorter than having it truncated at some arbitrary position.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D865

To: swhitaker, #hg-reviewers, ikostia
Cc: pulkit, ikostia, mercurial-devel


More information about the Mercurial-devel mailing list