D875: hgweb: use parsebool for parsing diff query string options
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sun Oct 1 09:26:04 EDT 2017
yuja accepted this revision.
yuja added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> webutil.py:181
> + v = util.parsebool(v)
> + setattr(diffopts, k, v if v is not None else True)
>
It might be better to ignore an invalid boolean, instead of falling back to True.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D875
To: indygreg, #hg-reviewers, simpkins, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list