D899: annotate: track whether a particular annotation was the result of a skip
sid0 (Siddharth Agarwal)
phabricator at mercurial-scm.org
Mon Oct 2 10:56:57 EDT 2017
sid0 added inline comments.
INLINE COMMENTS
> indygreg wrote in context.py:1164-1165
> I see that we're copying a ref to the object instead of making an object copy. When we had tuples, that was fine because tuples are immutable. But with attr, instances can be modified.
>
> Will this pose any problems?
Good question! Not in this case, because a particular annotation can never go from skip=True to skip=False. If we decide to overwrite the annotation afterwards, the whole object is replaced, not just fctx and lineno.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D899
To: sid0, #hg-reviewers
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list