D911: test-pager: make it work with chg
quark (Jun Wu)
phabricator at mercurial-scm.org
Mon Oct 2 23:12:14 UTC 2017
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
chg's runpager implementation is different. It behaves differently for the
"shell=False, command not found" case.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D911
AFFECTED FILES
tests/test-pager.t
CHANGE DETAILS
diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -195,6 +195,7 @@
paged! 'summary: modify a 8\n'
paged! '\n'
+#if no-chg
An invalid pager command name is reported sensibly if we don't have to
use shell=True in the subprocess call:
$ hg log --limit 3 --config pager.pager=this-command-better-never-exist
@@ -215,6 +216,17 @@
date: Thu Jan 01 00:00:00 1970 +0000
summary: modify a 8
+#else
+Currently, chg has its own runpager implementation, which does not show the
+"missing pager" message. The error message is globed out since the shell could
+print different message.
+ $ hg log --limit 3 --config pager.pager=this-command-better-never-exist
+ /bin/sh: this-command-better-never-exist: command not found (?)
+ * (glob) (?)
+ killed!
+ [255]
+
+#endif
A complicated pager command gets worse behavior. Bonus points if you can
improve this.
To: quark, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list