D943: chg: move only first time relevant if condition out of loop
singhsrb (Saurabh Singh)
phabricator at mercurial-scm.org
Thu Oct 5 18:48:02 EDT 2017
singhsrb added a comment.
In my opinion, just checking for `hg -R ... serve` would not solve the problem. If we go through that route, we would probably want to always detect the serve command rather than mostly detecting the serve command. However, if we do go in that direction and it makes sense to get rid of the special case for `i == 0`, then sure we should go ahead and delete this code whenever we do that.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D943
To: singhsrb, #hg-reviewers, yuja
Cc: yuja, quark, mercurial-devel
More information about the Mercurial-devel
mailing list