D966: hgweb: produce native string for etag value

quark (Jun Wu) phabricator at mercurial-scm.org
Thu Oct 5 21:58:07 EDT 2017


quark added inline comments.

INLINE COMMENTS

> common.py:211
>  def caching(web, req):
> -    tag = 'W/"%s"' % web.mtime
> +    tag = r'W/"%d"' % web.mtime
>      if req.env.get('HTTP_IF_NONE_MATCH') == tag:

It seems we are depending on `os.stat_float_times(False)`. But that is deprecated in Python 3. If the API gets removed, `mtime` might be a float.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D966

To: durin42, #hg-reviewers
Cc: quark, mercurial-devel


More information about the Mercurial-devel mailing list