D958: i18n: clean msgcache when encoding changes

quark (Jun Wu) phabricator at mercurial-scm.org
Fri Oct 6 13:27:42 EDT 2017


quark added a comment.


  In https://phab.mercurial-scm.org/D958#16241, @ryanmce wrote:
  
  > Is there a bugzilla bug where I can see what issue this addresses?
  
  
  There isn't. This series is to make ` test-commit-interactive.t` pass with chg.

INLINE COMMENTS

> lothiraldan wrote in encoding.py:596
> Should we catch exceptions here if a callback fails?

I think it's the callback's responsibility to catch exceptions if they need to. Besides, we don't do that for `hg.wirepeersetupfuncs`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D958

To: quark, #hg-reviewers
Cc: ryanmce, lothiraldan, mercurial-devel


More information about the Mercurial-devel mailing list